-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use fulfillment(of:) and address intermittent integration test failures #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:43 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:43 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 17, 2023 20:44 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:14 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Inactive
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Failure
atierian
had a problem deploying
to
IntegrationTest
October 18, 2023 14:15 — with
GitHub Actions
Failure
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:21 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:21 — with
GitHub Actions
Inactive
atierian
temporarily deployed
to
IntegrationTest
October 18, 2023 14:21 — with
GitHub Actions
Inactive
thisisabhash
approved these changes
Oct 18, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our E2E test suites have some intermittent failures for a variety of reasons. These changes address most of them:
XCTestCase.fulfillment(of:)
API when waiting onXCTestExpectation
s in async contexts.*Note:
All changes have been individually reviewed and approved already with the exception of a few minor changes. These can be seen here: 416a098...integrating-integration
General Checklist
New or updated tests includeGiven When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.