Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use fulfillment(of:) and address intermittent integration test failures #3305

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

atierian
Copy link
Member

@atierian atierian commented Oct 17, 2023

Description

Our E2E test suites have some intermittent failures for a variety of reasons. These changes address most of them:

*Note:

All changes have been individually reviewed and approved already with the exception of a few minor changes. These can be seen here: 416a098...integrating-integration

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian temporarily deployed to Fortify October 17, 2023 20:19 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:43 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:43 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 17, 2023 20:44 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:14 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:14 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:14 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:14 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:14 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:14 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:21 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:21 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 14:21 — with GitHub Actions Inactive
@atierian atierian merged commit 898713c into main Oct 18, 2023
3 checks passed
@atierian atierian deleted the integrating-integration branch October 18, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants