Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): Add isLoaded public property in List+Model #3296

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Oct 13, 2023

Issue #

#3286

Description

This public API change adds a isLoaded property in the List+Model public to help customers check if the list is loaded before calling fetch() to avoid network calls.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
    - [ ] Documentation update for the change if required
  • PR title conforms to conventional commit style
    - [ ] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
    - [ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner October 13, 2023 18:39
@codecov-commenter
Copy link

Codecov Report

Merging #3296 (629b91f) into main (ec5a64d) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   64.50%   64.33%   -0.18%     
==========================================
  Files        1075     1075              
  Lines       35880    35880              
==========================================
- Hits        23146    23082      -64     
- Misses      12734    12798      +64     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.15% <ø> (ø)
Amplify 47.84% <ø> (ø)
Analytics_plugin_unit_test 81.37% <ø> (ø)
Auth_plugin_unit_test 74.12% <ø> (+0.02%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.07% <ø> (-1.03%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 60.29% <ø> (ø)
Storage_plugin_unit_test 54.24% <ø> (ø)
unit_tests 64.33% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...y/Categories/DataStore/Model/Lazy/List+Model.swift 76.66% <ø> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thisisabhash thisisabhash temporarily deployed to Fortify October 13, 2023 19:02 — with GitHub Actions Inactive
@thisisabhash thisisabhash temporarily deployed to Fortify October 13, 2023 20:05 — with GitHub Actions Inactive
@thisisabhash thisisabhash changed the title feat(datastore): Make loadedState public in List+Model feat(datastore): Add isLoaded public property in List+Model Oct 13, 2023
@atierian atierian merged commit bdc9b4a into main Oct 19, 2023
76 checks passed
@atierian atierian deleted the feat/lazyloading-loadedState-changes branch October 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants