chore(unit tests): Adding additional unit tests #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
force-pushed
the
ruisebas/increase_unit_test_coverage
branch
from
8d13d0a to
e7c7943
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #3291 +/- ##
==========================================
+ Coverage 64.49% 66.81% +2.32%
==========================================
Files 1075 1075
Lines 35891 35851 -40
==========================================
+ Hits 23148 23954 +806
+ Misses 12743 11897 -846
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AmplifyPlugins/Storage/Sources/AWSS3StoragePlugin/Support/Internal/StorageTransferTask.swift
Show resolved
Hide resolved
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Models/AWSAuthCognitoSession.swift
Show resolved
Hide resolved
AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Dependency/AWSS3AdapterTests.swift
Show resolved
Hide resolved
...gnitoAuthPluginUnitTests/ActionTests/CredentialStore/MigrateLegacyCredentialStoreTests.swift
Outdated
Show resolved
Hide resolved
...nUnitTests/ActionTests/FetchAuthSession/FetchUserPoolTokens/RefreshHostedUITokensTests.swift
Outdated
Show resolved
Hide resolved
...nUnitTests/ActionTests/FetchAuthSession/FetchUserPoolTokens/RefreshHostedUITokensTests.swift
Outdated
Show resolved
Hide resolved
...ugins/Auth/Tests/AWSCognitoAuthPluginUnitTests/CognitoASFTests/CognitoUserPoolASFTests.swift
Outdated
Show resolved
Hide resolved
ruisebas
force-pushed
the
ruisebas/increase_unit_test_coverage
branch
from
e7c7943 to
b2ccaf8
Compare
harsh62
previously approved these changes
Oct 18, 2023
thisisabhash
previously approved these changes
Oct 18, 2023
| import XCTest | ||
|
|
||
| class CognitoUserPoolASFTests: XCTestCase { | ||
| private var pool: CognitoUserPoolASF! |
| // | ||
|
|
||
| @testable import Amplify | ||
| //@testable import func AmplifyTestCommon.XCTAssertThrowFatalError |
There was a problem hiding this comment.
can remove the comment if not needed
ruisebas
force-pushed
the
ruisebas/increase_unit_test_coverage
branch
from
bae48a2 to
bcec936
Compare
harsh62
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional unit tests to the following targets:
It also removes some orphaned code found around :)
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.