Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding privacy info #3265

Closed
wants to merge 42 commits into from
Closed

adding privacy info #3265

wants to merge 42 commits into from

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Oct 3, 2023

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #3265 (76dd40e) into main (fc9fe26) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
- Coverage   64.77%   64.73%   -0.05%     
==========================================
  Files        1094     1094              
  Lines       37260    37260              
==========================================
- Hits        24135    24119      -16     
- Misses      13125    13141      +16     
Flag Coverage Δ
API_plugin_unit_test 67.10% <ø> (ø)
AWSPluginsCore 65.86% <ø> (ø)
Amplify 47.86% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 86.39% <ø> (ø)
Auth_plugin_unit_test 74.93% <ø> (-0.16%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.68% <ø> (+0.01%) ⬆️
Geo_plugin_unit_test 84.28% <ø> (ø)
Logging_plugin_unit_test 63.41% <ø> (ø)
Predictions_plugin_unit_test 34.87% <ø> (ø)
PushNotifications_plugin_unit_test 69.69% <ø> (ø)
Storage_plugin_unit_test 54.07% <ø> (ø)
unit_tests 64.73% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ruisebas and others added 28 commits October 3, 2023 15:34
* test(logging): fix integration tests

* test(logging): fix integration tests

* test(logging): clean up test schemes

* test: fixing integration test workflow

* test: updating integration test workflows

* update integ workflow

* fix logging watchos integ test

* chore: update logging integration test to run in parallel
* fix(storage): add metadata support

* fix(storage): fix missing parameter build error

* fix(storage): fix storage unit tests

* fix(storage): add metadata support to multipart upload

* fix(storage): add metadata support to multipart upload
@harsh62 harsh62 temporarily deployed to Fortify November 3, 2023 01:35 — with GitHub Actions Inactive
@harsh62 harsh62 closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants