fix: new error handling in auth plugin unit test suites #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
atierian
commented
Sep 29, 2023
| @@ -221,7 +228,7 @@ class SetUpTOTPTaskTests: BasePluginTest { | |||
| XCTFail("Should produce service error instead of \(error)") | |||
| return | |||
| } | |||
| guard case .mfaMethodNotFound = (underlyingError as? AWSCognitoAuthError) else { | |||
| guard case .softwareTokenMFANotEnabled = (underlyingError as? AWSCognitoAuthError) else { | |||
There was a problem hiding this comment.
This is necessary because we were previously mapping to the wrong underlyingError.
atierian
commented
Sep 29, 2023
| @@ -175,14 +180,15 @@ class VerifyTOTPSetupTaskTests: BasePluginTest { | |||
| /// - When: | |||
| /// - I invoke verifyTOTPSetup | |||
| /// - Then: | |||
| /// - I should get a .service error with .mfaMethodNotFound as underlyingError | |||
| /// - I should get a .service error with .softwareTokenMFANotEnabled as underlyingError | |||
There was a problem hiding this comment.
We were previously mapping to the wrong underlyingError.
atierian
commented
Sep 29, 2023
| @@ -193,7 +199,7 @@ class VerifyTOTPSetupTaskTests: BasePluginTest { | |||
| XCTFail("Should produce service error instead of \(error)") | |||
| return | |||
| } | |||
| guard case .mfaMethodNotFound = (underlyingError as? AWSCognitoAuthError) else { | |||
| guard case .softwareTokenMFANotEnabled = (underlyingError as? AWSCognitoAuthError) else { | |||
There was a problem hiding this comment.
We were previously mapping to the wrong underlyingError.
atierian
commented
Sep 29, 2023
| @@ -417,7 +424,7 @@ class ConfirmSignInWithSetUpMFATaskTests: BasePluginTest { | |||
| XCTFail("Should produce service error instead of \(error)") | |||
| return | |||
| } | |||
| guard case .mfaMethodNotFound = (underlyingError as? AWSCognitoAuthError) else { | |||
| guard case .softwareTokenMFANotEnabled = (underlyingError as? AWSCognitoAuthError) else { | |||
There was a problem hiding this comment.
We were previously mapping to the wrong underlyingError.
atierian
commented
Sep 29, 2023
| @@ -493,7 +493,7 @@ class SignInSetUpTOTPTests: BasePluginTest { | |||
| XCTFail("Should not produce result - \(result)") | |||
| } catch { | |||
| guard case AuthError.service(_, _, let underlyingError) = error, | |||
| case .mfaMethodNotFound = (underlyingError as? AWSCognitoAuthError) else { | |||
| case .softwareTokenMFANotEnabled = (underlyingError as? AWSCognitoAuthError) else { | |||
There was a problem hiding this comment.
We were previously mapping to the wrong underlyingError.
harsh62
approved these changes
Sep 29, 2023
atierian
commented
Sep 29, 2023
Comment on lines
+17
to
+18
| @MainActor | ||
| func testAuthCognitoPlugin() async { |
There was a problem hiding this comment.
async bubbled up to this test from a change in the SDK. It needs to be @MainActor because async and XCTContext.runActivity do not play nicely together otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift SDK Update 0.26.0
Makes necessary changes to get AWSCognitoAuthPlugin unit test suites to build and tests passing.
Debt Introduced
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.