fix(auth): fall back to user agent if deviceName resolves to empty st… #14102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ring
Description of changes
This PR updates the device name resolution to fall back to using the user agent if it resolves to
''. This might happen when theuserAgentDatareturns empty values for the requested information - something that happens when simulating devices in Chrome, for example.Currently, the device name already falls back to user agent in the case
userAgentDatais not supported on the platform so this PR only applies the same fallback logic to the case whereuserAgentDatais supported but is reporting empty values.Issue #, if available
#14100
Description of how you validated changes
Reproduced issue using Chrome browser and validated that DeviceName is no longer sent with empty string when device tracking is enabled.
Manually tested against Firefox and Safari.
Added unit tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.