Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): catch type issues when configuring from external json #14101

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashwinkumar6
Copy link
Member

@ashwinkumar6 ashwinkumar6 commented Dec 27, 2024

Description of changes

  • Bug fix
    • Update AmplifyOutputs authentication_flow_type type from string literal union to string
  • Test
    • Ensure amplify_outputs.json has all combinations defined, else throw type error (CI failure)
    • Ensure TS inferred shape from external json does not throw type issues with Amplify.configure (CI failure)

Description of how you validated changes

linked ^

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant