Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up #13839

Merged

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 23, 2024

Description of changes

  • Add a check to determine whether an end user has already signed in before initiating a sign-in or sign-up flow

Issue #, if available

Description of how you validated changes

  • Unit tests
  • Manual testing with next.js sample apps created with the app router and the pages router.

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/3-auth-api-handlers-impl branch from 621d0cb to 284acbf Compare October 1, 2024 23:02
@HuiSF HuiSF requested a review from a team as a code owner October 1, 2024 23:02
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/4-check-signed-in-user branch from 583f9f0 to df708b8 Compare October 1, 2024 23:03
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/3-auth-api-handlers-impl branch from 284acbf to 0ef2b81 Compare November 21, 2024 17:06
@HuiSF HuiSF requested a review from pranavosu as a code owner November 21, 2024 17:06
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/4-check-signed-in-user branch from df708b8 to 1cd0bd6 Compare November 21, 2024 17:06
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/3-auth-api-handlers-impl branch from 0ef2b81 to ff48e7a Compare December 21, 2024 00:30
@HuiSF HuiSF requested a review from sktimalsina as a code owner December 21, 2024 00:30
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/4-check-signed-in-user branch from 1cd0bd6 to a89048c Compare December 23, 2024 22:57
Base automatically changed from hui/feat/adapter-nextjs/3-auth-api-handlers-impl to feat/server-auth/main January 2, 2025 21:48
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/4-check-signed-in-user branch from 4d283b0 to 3ec76df Compare January 2, 2025 22:11
@HuiSF HuiSF merged commit 0c1f25c into feat/server-auth/main Jan 2, 2025
28 checks passed
@HuiSF HuiSF deleted the hui/feat/adapter-nextjs/4-check-signed-in-user branch January 2, 2025 23:40
HuiSF added a commit that referenced this pull request Jan 6, 2025
…sign-in and sign-up (#13839)

* feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up

* chore(adapter-nextjs): rename hasUserSignedIn to hasActiveUserSession
HuiSF added a commit that referenced this pull request Jan 9, 2025
…sign-in and sign-up (#13839)

* feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up

* chore(adapter-nextjs): rename hasUserSignedIn to hasActiveUserSession
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants