Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workspace): use typescript ~5.3.0 across the workspace #13416

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented May 22, 2024

Description of changes

We can now use typescript 5.3.x across the workspace.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested review from a team as code owners May 22, 2024 23:10
Copy link

⚠️ This PR includes changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not manually change "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library
  • Remove any export paths without a major version bump

A repository administrator is required to review this change.

jimblanc
jimblanc previously approved these changes May 22, 2024
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuiSF HuiSF force-pushed the hui/chore/baseline-ts-version branch from 9abb779 to 73fe129 Compare May 22, 2024 23:49
@HuiSF HuiSF changed the title chore(workspace): use typescript 5.0.2 across the workspace chore(workspace): use typescript ~5.3.0 across the workspace May 22, 2024
cshfang
cshfang previously approved these changes May 22, 2024
jimblanc
jimblanc previously approved these changes May 22, 2024
ashika112
ashika112 previously approved these changes May 23, 2024
@HuiSF HuiSF dismissed stale reviews from ashika112, jimblanc, and cshfang via e91356c May 23, 2024 23:51
cshfang
cshfang previously approved these changes May 23, 2024
jimblanc
jimblanc previously approved these changes May 24, 2024
@HuiSF HuiSF dismissed stale reviews from jimblanc and cshfang via 52acbae May 24, 2024 15:35
@@ -122,7 +122,7 @@
"typedoc": "0.25.8",
"typedoc-plugin-extras": "^3.0.0",
"typedoc-plugin-missing-exports": "^2.2.0",
"typescript": "^4.6.0",
"typescript": "~5.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ~ vs hard dependency or ^?

@iartemiev iartemiev requested a review from haverchuck as a code owner October 28, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants