feat(migrate-template-gen): add category template generator #13962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/amplify-migration-template-gen/src/category-template-generator.ts
Fixed
Show fixed
Hide fixed
abhi7cr
commented
Oct 7, 2024
| @@ -11,7 +11,7 @@ class CfnParameterResolver { | |||
| const parametersFromTemplate = this.template.Parameters; | |||
| for (const { ParameterKey, ParameterValue } of parameters) { | |||
| assert(ParameterKey); | |||
| assert(ParameterValue); | |||
| if (!ParameterValue) continue; | |||
There was a problem hiding this comment.
there are keys with null/undefined values.
abhi7cr
commented
Oct 7, 2024
| assert(stackOutputs); | ||
| assert(stackTemplateOutputs); | ||
| let stackTemplateResourcesString = JSON.stringify(stackTemplateResources); |
There was a problem hiding this comment.
the main change here is to only replace Refs within Resources section rather than the entire template. This way Outputs section Ref values can be replaced later on with stack outputs
Sanayshah2
approved these changes
Oct 7, 2024
sobolk
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add category template generator to output CFN templates for each step of refactor. The class is category agnostic and will expose 3 methods to facilitate generation of templates needed for refactor:
Note: Each step generates the necessary templates under
.amplify/migration/templates/<category>folder but the steps will be executed later on by the customer following theREADME.mdfile.Description of how you validated changes
Local testing, unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.