Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: storage category codegen #13928

Merged
merged 28 commits into from
Sep 19, 2024
Merged

Conversation

Sanayshah2
Copy link
Contributor

@Sanayshah2 Sanayshah2 commented Sep 17, 2024

Description of changes

  • Added logic to generate code for supported storage category features. Overrides for s3 bucket resource are generated in backend.ts file
  • Added a few missing tests for auth external providers.
  • Modifications to add overrides as assignments instead of using addPropertyOverride()
  • Fix import statements codegen for specific resource

Description of how you validated changes

Unit tests, manual validation, sandbox deployment validation

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Sanayshah2 Sanayshah2 marked this pull request as ready for review September 18, 2024 00:23
@Sanayshah2 Sanayshah2 requested a review from a team as a code owner September 18, 2024 00:23
@Sanayshah2 Sanayshah2 requested review from abhi7cr and removed request for a team September 18, 2024 00:30
@Sanayshah2 Sanayshah2 merged commit 936c15c into aws-amplify:migrations Sep 19, 2024
3 checks passed
@Sanayshah2 Sanayshah2 deleted the storage branch September 20, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants