Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message when expecting S3 to throw #13923

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Sep 11, 2024

Description of changes

Currently S3 access E2E tests are looking for Access Denied when expecting user group that does not have permissions to interact with S3 bucket. The new message received is now something like:

User: <user group arn> is not authorized to perform: s3:GetObject on resource: <S3 bucket> because no identity-based policy allows the s3:GetObject action

Update E2E test to expect not authorized to perform instead of Access Denied.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rtpascual rtpascual changed the title fix: update message when expecting s3 to throw fix: update message when expecting S3 to throw Sep 12, 2024
@rtpascual rtpascual marked this pull request as ready for review September 12, 2024 00:58
@rtpascual rtpascual requested a review from a team as a code owner September 12, 2024 00:58
@rtpascual rtpascual merged commit e1ce6bc into dev Sep 12, 2024
6 checks passed
@rtpascual rtpascual deleted the update-s3-access-e2e branch September 12, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants