Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump api plugin, codegen dependencies #13921

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Sep 11, 2024

Description of changes

  • Update the script used that bumps versions of API plugin dependency packages to use the stable dist-tag api-plugin-stable that is published from our stable branch.
  • Bump the API and codegen package dependencies.

Issue #, if available

Description of how you validated changes

Full E2E Link. Re-trying few failures from first run.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner September 11, 2024 00:25
Comment on lines +142 to +145
verifySinglePkg "amplify-pkg-linux-x64" "amplify-pkg-linux-x64.tgz" $((925 * 1024 * 1024))
verifySinglePkg "amplify-pkg-macos-x64" "amplify-pkg-macos-x64.tgz" $((925 * 1024 * 1024))
verifySinglePkg "amplify-pkg-win-x64.exe" "amplify-pkg-win-x64.tgz" $((925 * 1024 * 1024))
verifySinglePkg "amplify-pkg-linux-arm64" "amplify-pkg-linux-arm64.tgz" $((750 * 1024 * 1024))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why this grew ~100MB ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency update for AWS SDK libraries to use 3.621.0 - aws-amplify/amplify-category-api#2746 might have caused this size increase. This went in API plugin version 5.12.6 and was needed to remove vulnerable fast-xml version.

@phani-srikar phani-srikar force-pushed the guest/data/bump-data-dependencies branch from 979e28a to c7d58e3 Compare September 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants