Functions codegen #13915
Merged
Functions codegen #13915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzsurbhi
requested review from
abhi7cr and
sobolk
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
abhi7cr
reviewed
Sep 18, 2024
abhi7cr
reviewed
Sep 18, 2024
abhi7cr
approved these changes
Sep 18, 2024
sobolk
reviewed
Sep 18, 2024
sobolk
reviewed
Sep 19, 2024
packages/amplify-gen2-codegen/API.md
Outdated
Comment on lines
236
to
238
| // Warnings were encountered during analysis: | ||
| // | ||
| // src/auth/source_builder.ts:101:3 - (ae-forgotten-export) The symbol "AttributeMappingRule" needs to be exported by the entry point index.d.ts |
sobolk
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Properties getting added:
export const amplifymigrateecd61fbc = defineFunction({
entry: "./amplifymigrateecd61fbc/src/handler.ts",
name: "amplifymigrateecd61fbc-dev",
timeoutSeconds: 25,
memoryMB: 128,
environment: { ENV: "dev", REGION: "us-west-2" },
runtime: 18
});
Description of how you validated changes
Deployed the changes to sandbox, verified function resource getting created successfully
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.