-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn modern install workspace #13197
Conversation
Can't we use this new https://yarnpkg.com/configuration/yarnrc#nmHoistingLimits i.e. creating Also we should have automated tests for this change. |
That's a good point. Thanks for pointing it out.
However, it work either of the following case:
Option 1 is not good because I don't think we want to modify anything outside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add tests.
failed e2e tests are: l_diagnose_hooks_a_mock_api and l_function_3a_init_special_case_http_migration, which are the same as the |
Description of changes
Issue: Modern Yarn (2,3) doesn't create yarn.lock when running
yarn install
if it can find a yarn.lock in it's parent directory. So we can see the folloing error:#13001
Fix: Add yarn.lock to category resources directories if there's no yarn.lock
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.