Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2306

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Update README.md #2306

merged 4 commits into from
Dec 10, 2024

Conversation

PawanMude
Copy link
Contributor

@PawanMude PawanMude commented Dec 7, 2024

Added Amplify Logo

Problem

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Added Amplify Logo
@PawanMude PawanMude requested a review from a team as a code owner December 7, 2024 04:27
@PawanMude
Copy link
Contributor Author

Added Amplify Logo in the file.

@PawanMude
Copy link
Contributor Author

@sobolk and @rtpascual ; can you please review this request?

@sobolk
Copy link
Member

sobolk commented Dec 9, 2024

@josefaidt is this fine?

@josefaidt
Copy link
Contributor

Hey @PawanMude thank you for taking the time to file this! Do you mind if we pivot to using one of the logo assets from the Amplify documentation site? There are a few different sizes available
https://docs.amplify.aws/assets/icon/favicon-purple-32x32.png
https://docs.amplify.aws/assets/icon/favicon-purple-64x64.png

You can see the other sizes here https://github.com/aws-amplify/docs/blob/main/public/assets/icon/favicon-purple-64x64.png

README.md Outdated Show resolved Hide resolved
Updated Update README.md with Amplify Doc link

Co-authored-by: Kamil Sobol <[email protected]>
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 61b76e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PawanMude
Copy link
Contributor Author

Hey @PawanMude thank you for taking the time to file this! Do you mind if we pivot to using one of the logo assets from the Amplify documentation site? There are a few different sizes available https://docs.amplify.aws/assets/icon/favicon-purple-32x32.png https://docs.amplify.aws/assets/icon/favicon-purple-64x64.png

You can see the other sizes here https://github.com/aws-amplify/docs/blob/main/public/assets/icon/favicon-purple-64x64.png

@josefaidt : I've been using AWS Amplify pretty much since day one of it's launch, and the orange logo just fits the AWS vibe. The blue one, though, gives off the feeling that ; someone at AWS is missing Azure :) Logo is like a national flag for the community - we don’t keep changing the colors just because there’s a shift in leadership across the legislative, executive, and judicial branches.

Sometimes we need to agree to disagree; so if change is the flavor, and if you still want me to update the logo, I'm fine going with the community.

Updated new Logo
@PawanMude
Copy link
Contributor Author

@josefaidt can you please review updates?

README.md Outdated Show resolved Hide resolved
Co-authored-by: josef <[email protected]>
@sobolk sobolk enabled auto-merge (squash) December 10, 2024 17:02
@sobolk sobolk disabled auto-merge December 10, 2024 17:15
@sobolk sobolk merged commit a713a02 into aws-amplify:main Dec 10, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants