Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade execa #2303

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Upgrade execa #2303

merged 6 commits into from
Dec 6, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Dec 6, 2024

Problem

Fixes #962 .

We're on older unmaintained line of execa.

Issue number, if available:
#962

Changes

Execa had breaking changes in the API, therefore we can't use 5.x types anymore. And we can't use execa in plugin types either due to ESM - CommonJS compatibility issue.

  1. Define our own types for execa for package manager use cases.
  2. Drop dev dependency on execa from plugin types
  3. Upgrade execa to latest everywhere.
  4. Code changes to accommodate breaks. (these were only in integration test package, therefore we're good to roll this without MV bump).

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Dec 6, 2024
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: ff8759d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@aws-amplify/backend-deployer Patch
@aws-amplify/backend-function Patch
create-amplify Patch
@aws-amplify/plugin-types Minor
@aws-amplify/cli-core Patch
@aws-amplify/backend-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk marked this pull request as ready for review December 6, 2024 22:37
@sobolk sobolk requested review from a team as code owners December 6, 2024 22:37
@sobolk sobolk merged commit f6ba240 into main Dec 6, 2024
84 checks passed
@sobolk sobolk deleted the update-execa branch December 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make execa version consistent
3 participants