Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotswap to canaries #2289

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Add hotswap to canaries #2289

merged 9 commits into from
Dec 3, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Dec 2, 2024

Problem

Our canary checks don't include any hotswap scenarios.

This would have caught this regression right after CDK release - aws/aws-cdk#32219 .

Function code hotswap is our P0 scenario, so we should catch regressions there fast.

Changes

  1. Add test project with function hotswap
  2. Include it in canary checks

Validation

Canary run https://github.com/aws-amplify/amplify-backend/actions/runs/12145216809

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Dec 2, 2024
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: b6fb2e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk marked this pull request as ready for review December 2, 2024 23:59
@sobolk sobolk requested a review from a team as a code owner December 2, 2024 23:59
vigy02
vigy02 previously approved these changes Dec 3, 2024
awsluja
awsluja previously approved these changes Dec 3, 2024
Copy link
Member Author

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had an offline chat with @Amplifiyer .

I'll refactor this PR to :

  1. decouple new scenario from e2e tests.
  2. focus scenario on "hotswap function code" use case.

Amplifiyer
Amplifiyer previously approved these changes Dec 3, 2024
Comment on lines 36 to 37
export const waitForSandboxToHotswapResources = () =>
new PredicatedActionBuilder().waitForLineIncludes('hotswapping resources:');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just to be more explicit

Suggested change
export const waitForSandboxToHotswapResources = () =>
new PredicatedActionBuilder().waitForLineIncludes('hotswapping resources:');
export const waitForSandboxToBeginHotswappingResources = () =>
new PredicatedActionBuilder().waitForLineIncludes('hotswapping resources:');

@sobolk sobolk merged commit 1f56a5f into main Dec 3, 2024
80 of 81 checks passed
@sobolk sobolk deleted the hotswap-in-canaries branch December 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants