-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hotswap to canaries #2289
Add hotswap to canaries #2289
Conversation
🦋 Changeset detectedLatest commit: b6fb2e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/integration-tests/src/test-live-dependency-health-checks/health_checks.test.ts
Fixed
Show fixed
Hide fixed
packages/integration-tests/src/test-live-dependency-health-checks/health_checks.test.ts
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had an offline chat with @Amplifiyer .
I'll refactor this PR to :
- decouple new scenario from e2e tests.
- focus scenario on "hotswap function code" use case.
export const waitForSandboxToHotswapResources = () => | ||
new PredicatedActionBuilder().waitForLineIncludes('hotswapping resources:'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: just to be more explicit
export const waitForSandboxToHotswapResources = () => | |
new PredicatedActionBuilder().waitForLineIncludes('hotswapping resources:'); | |
export const waitForSandboxToBeginHotswappingResources = () => | |
new PredicatedActionBuilder().waitForLineIncludes('hotswapping resources:'); |
Problem
Our canary checks don't include any hotswap scenarios.
This would have caught this regression right after CDK release - aws/aws-cdk#32219 .
Function code hotswap is our P0 scenario, so we should catch regressions there fast.
Changes
Validation
Canary run https://github.com/aws-amplify/amplify-backend/actions/runs/12145216809
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.