feed pr base sha and ref into envs before scripts (#2168)

* feed pr base sha and ref into envs before scripts * removing empty file
aws-amplify · Dec 3, 2024 · 63efabb · 63efabb
1 parent ad0a911
commit 63efabb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/spicy-rules-speak.md b/.changeset/spicy-rules-speak.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/.github/workflows/health_checks.yml b/.github/workflows/health_checks.yml
@@ -411,7 +411,9 @@ jobs:
       - uses: ./.github/actions/setup_node
       - uses: ./.github/actions/restore_install_cache
       - run: git fetch origin
-      - run: npm run diff:check ${{ github.event.pull_request.base.sha }}
+      - run: npm run diff:check "$BASE_SHA"
+        env:
+          BASE_SHA: ${{ github.event.pull_request.base.sha }}
   check_pr_changesets:
     if: github.event_name == 'pull_request' && github.event.pull_request.user.login != 'github-actions[bot]'
     runs-on: ubuntu-latest
@@ -425,9 +427,13 @@ jobs:
       - uses: ./.github/actions/setup_node
       - uses: ./.github/actions/restore_install_cache
       - name: Validate that PR has changeset
-        run: npx changeset status --since origin/${{ github.event.pull_request.base.ref }}
+        run: npx changeset status --since origin/"$BASE_REF"
+        env:
+          BASE_REF: ${{ github.event.pull_request.base.ref }}
       - name: Validate changeset is not missing packages
-        run: npx tsx scripts/check_changeset_completeness.ts ${{ github.event.pull_request.base.sha }}
+        run: npx tsx scripts/check_changeset_completeness.ts "$BASE_SHA"
+        env:
+          BASE_SHA: ${{ github.event.pull_request.base.sha }}
       - name: Validate that changeset has necessary dependency updates
         run: |
           npx changeset version