Add completion for bash & zsh #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a completion script to be installed, a few conditions need to be met * The shell should be installed * docker installed and the user part of the docker group Additional message for zsh users to include bashcompinit zsh version has autocompletion, bash will simply list all existing images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to address #5
I changed the install shell to bash to be able to do if checks with multiple comparisons. I'm not sure this is possible in sh
For a completion script to be installed, a few conditions need to be met:
Additional message for zsh users to include
bashcompinitzsh version has autocompletion, bash will simply list all existing images.
The bash completions script is added to
/etc/bash_completion.d/dockitzsh is added to
/usr/share/zsh/vendor-completions/_dockitI've tested both in the ubuntu image and they seem to be working well.
Bash needs
bash-completioninstalled and zsh needsbashcompinitin~/.zshrc.Make sure if testing to switch to a non-root user.