1.4.4: Add reverse encoders for packed repeated fields. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the Vector encoders but unlike the forward-order Foldable encoders they avoid the need to save elements to the stack before encoding them, instead immediately encoding the final element as the first step. However, the new encoders lack the special optimizations around size checks that are possible for the Vector encoders, which have advance knowledge of the number of elements. This change also avoids compiler warnings in benchmark code.
They are no more unsafe than unsafeFromLazyByteString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the Vector encoders but unlike the forward-order Foldable encoders they avoid the need to save elements to the stack before encoding them, instead immediately encoding the final element as the first step. However, the new encoders lack the special optimizations around size checks that are possible for the Vector encoders, which have advance knowledge of the number of elements.
This change also avoids compiler warnings in benchmark code.
NOTE: This change should not be merged until we confirm that it is useful downstream in proto3-suite. This note will be removed when that confirmation is obtained. Meanwhile please do not feel obliged to review this PR (though comments are welcome if you feel inspired).