Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC install instructions and production warning #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manojpramesh
Copy link
Contributor

GRPC installation instruction for UNIX based systems and a warning for production use.

README.md Outdated Show resolved Hide resolved
@@ -119,6 +119,27 @@ There are basically two methods to accomplish this:
sha256 "efad782944da13d362aab9b81f001b7b8b1458794751de818e9848c47acd4b32"
```

Installing GRPC on Unix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of recommending that the user clone the repo and update the submodules, I think we should instead recommend downloading the release package from the project's release page: https://github.com/grpc/grpc/releases.

e.g.

1. Download the 1.2 release: `curl -O https://github.com/grpc/grpc/archive/v1.2.0.tar.gz`
...

Even better is if we can suggest installation via a specific distro's package manager but I don't know how many versions of grpc core are available for Debian, etc.

RichardWarfield pushed a commit to litxio/gRPC-haskell that referenced this pull request Apr 25, 2023
There's a bug with GHCJS, boxed tuples, and inlining, but it's hard to
pin down, so I just disabled inlining in the two places it was being used
for that compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants