Grpc 1.45+ support #157
Merged
Grpc 1.45+ support #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I was working on a similar change on my side but couldn't get the nix bits to work. If I understand your PR correctly, after this change the gRCP-haskell library won't let you create insecure connections anymore. I think there is a way to preserve the existing API, which allows to create insecure connections. The grpc C library lets you create insecure credentials, which you can then pass to |
|
Oh hey! Thanks for the tip! I think that should push this over the line! |
Instead of making secure connections mandatory, use insecure credentials to keep existing API unchanged.
It seems as though the `./Setup sdist` now unsets the executable bit.
jsoo1
commented
Nov 8, 2023
rkaippully
approved these changes
Nov 9, 2023
|
Thanks a lot, @jsoo1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.