Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gamedata/spells endpoint #63

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

VeryGreatFrog
Copy link
Contributor

@VeryGreatFrog VeryGreatFrog commented Aug 22, 2024

This should have existed.
https://avrae.readthedocs.io/en/stable/automation_ref.html#CastSpell.id

Summary

Add the endpoint for spells gamedata that should have existed according to the documentation. There is no other way to get this data, as gamedata/entitlements is incomplete when it comes to SRD spells.

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.

@VeryGreatFrog
Copy link
Contributor Author

Having finally been able to test it, this endpoint actually shows more data than I was expecting. Hold on tight for some changes

@VeryGreatFrog
Copy link
Contributor Author

Tested and works as expected.
image
ready to merge @SeanStoves

@VeryGreatFrog
Copy link
Contributor Author

Alternatively, it can also be changed to show similar to how entitlements show their data, with their type, link to beyond, entity type, etc, but I don't think that is terribly useful.

@SeanStoves
Copy link
Contributor

@VeryGreatFrog , if you can run blackify on it, I'll get it merged ;)

@VeryGreatFrog
Copy link
Contributor Author

@SeanStoves I gotta be honest, I don't have that set up well and it is failing not on my code, so not something I am going to concern myself with!

@SeanStoves SeanStoves merged commit 9362e89 into avrae:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants