1133 | Allow adding questionGroup only if none of the existing ones …

…are empty
avniproject · Jun 10, 2024 · a0a9002 · a0a9002
1 parent caa63e4
commit a0a9002
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/dataEntryApp/components/QuestionGroupFormElement.js b/src/dataEntryApp/components/QuestionGroupFormElement.js
@@ -72,7 +72,7 @@ export default function QuestionGroupFormElement({
               concept={childFormElement.concept}
               obsHolder={obsHolder}
               value={value}
-              validationResults={validationResults.filter(itr => itr.questionGroupIndex === questionGroupIndex)}
+              validationResults={validationResults}
               uuid={childFormElement.uuid}
               update={newValue => {
                 updateObs(formElement, newValue, childFormElement, questionGroupIndex);

diff --git a/src/dataEntryApp/components/RepeatableQuestionGroupElement.js b/src/dataEntryApp/components/RepeatableQuestionGroupElement.js
@@ -31,16 +31,19 @@ export function RepeatableQuestionGroupElement({
   if (hasNoObservation) repeatableQuestionGroup = new RepeatableQuestionGroup();
   const repeatableQuestionGroupValue = repeatableQuestionGroup.getValue();
   const hasMultipleElements = repeatableQuestionGroupValue.length > 1;
+  const oneOfTheQuestionGroupObservationsIsEmpty = _.some(repeatableQuestionGroupValue, x => _.isEmpty(x.groupObservations));
   return repeatableQuestionGroupValue.map((x, index) => {
-    const isLastElement = !hasNoObservation && repeatableQuestionGroupValue.length === index + 1;
+    const isLastElement =
+      !hasNoObservation && !oneOfTheQuestionGroupObservationsIsEmpty && repeatableQuestionGroupValue.length === index + 1;
+    const quesGrpValidationResults = validationResults.filter(itr => itr.questionGroupIndex === index);
     return (
       <div key={index}>
         <QuestionGroupFormElement
           formElement={formElement}
           filteredFormElements={filteredFormElements}
           obsHolder={obsHolder}
           updateObs={updateObs}
-          validationResults={validationResults}
+          validationResults={quesGrpValidationResults}
           isRepeatable={true}
           questionGroupIndex={index}
           key={index}