95 bugfix/form not hyperlinked #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourginakis
suggested changes
Oct 23, 2023
|
I think it may be better if we use Edit: I just did this with |
mourginakis
reviewed
Oct 24, 2023
tests/test_bot_telegram.py
Outdated
Comment on lines
31
to
49
| ## Create a fake node model | ||
| fakenode = ic_api.Node( | ||
| dc_id = 'fake_dc_id', | ||
| dc_name = 'fake_dc_name', | ||
| node_id = 'fake_node_id', | ||
| node_operator_id = 'fake_node_operator_id', | ||
| node_provider_id = 'fake_node_provider_id', | ||
| node_provider_name = 'fake_node_provider_name', | ||
| owner = 'fake_owner', | ||
| region = 'fake_region', | ||
| status = 'DOWN', | ||
| subnet_id = 'fake_subnet_id', | ||
| ) | ||
| fakelabel = {'fake_node_id': 'fake_label'} | ||
|
|
||
| with patch.object(c, 'FEEDBACK_FORM_URL', 'https://url-has-been-redacted.ninja'): | ||
| subject1, message1 = messages.nodes_down_message([fakenode], fakelabel) | ||
| subject2, message2 = messages.nodes_status_message([fakenode], fakelabel) | ||
|
|
There was a problem hiding this comment.
We're repeating this code 3 times.
I suggest one of:
- We test sending a short simple string in both
test_bot_slack.pyandtest_bot_telegram.pylike before, and use only the public inbox to make sure the messages look like how we want them. Keep the codebase a bit smaller. - We move this logic outside of these test functions, compute once and store it in
conftest.py. - Leave as is.
I'm kind of in favor of option 1. Thoughts?
mourginakis
approved these changes
Oct 25, 2023
mourginakis
suggested changes
Oct 26, 2023
mourginakis
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
Description
Include a link to a feedback form in all messages sent from Node Monitor.
Changes made
messages.py.test_bot_telegramandtest_bot_slackto use message templates when sending live messages during testing.Testing
Additional comments
n/a