Leak detecting #18
Closed
Leak detecting #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for writing this class for us. You are a magical unicorn. |
|
|
||
| while (true) { | ||
| while (!hasLeak) { |
There was a problem hiding this comment.
if we stop running the main loop upon leak, the mbed will appear to have crashed. Also, pololu may still have motor values cached.
This may have to be re-calibrated with TRANSDEC water, which I expect will have more ions dissolved.
It's good to know why your sub randomly stops running
If there is a leak, won't turn the sub back on until mbed reset.
|
Totally went overboard with this leak detection thing. We're going to have the best safety features at RoboSub. Still need to test the code. |
I am bad at programming.
This almost eliminates false positives when the analogin pin is floating
|
@aditsinha Can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to add pull requests to existing issues apparently. This should add leak detection functionality (per #17)