Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update debugger.py #139

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Update debugger.py #139

merged 3 commits into from
Oct 23, 2023

Conversation

ruppde
Copy link
Contributor

@ruppde ruppde commented Oct 8, 2023

Show absolute path in codelens "Select hash for context" error message to avoid indistinct "Sample abc not found in ."

ruppde and others added 3 commits October 8, 2023 09:01
@ruppde
Update debugger.py
979a39d 
Show absolute path in codelens "Select hash for context" error message to avoid indistinct "Sample abc not found in ."
@ruppde
Update debugger.py
1af4097 
fix black
@MatejKastak
feat(debugger): Normalize the samples_dir path
c15681d 
Normalize the path right at the start when we request it through LSP get
config. This way we will see the absolute path in the error message and
also add support for the path relative to the user (home) directory.
@MatejKastak MatejKastak self-requested a review October 23, 2023 12:49
MatejKastak
MatejKastak approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@MatejKastak MatejKastak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply, but thank you very much. I tweaked your PR a bit and I will try to release a new version and checkout rest of your PRs soon. Thanks for your contribution 🙏

@MatejKastak MatejKastak self-assigned this Oct 23, 2023
@MatejKastak MatejKastak merged commit 8afe641 into avast:master Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatejKastak MatejKastak MatejKastak approved these changes

Assignees

@MatejKastak MatejKastak

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruppde @MatejKastak