Make container scopes configurable fix solution #103
Conversation
…r container-scope
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Its sort of stale, but what's the difference with #91 ? |
I agree it is not too much but as the comment #91 (comment) said the mr is not working. I found out the pytest_addoptions is on the wrong place and the mr request was containing a typo and haven‘t any integration tests |
I will update the README.md, too. |
setup.cfg
Outdated
| @@ -1,6 +1,6 @@ | |||
| [metadata] | |||
| name = pytest-docker | |||
| version = 2.0.1 | |||
| version = 2.1.0 | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/pytest_docker/plugin.py
Outdated
| return request.config.getoption("--container-scope") | ||
|
|
||
| def containers_scope(fixture_name, config): | ||
| return config.getoption("--container-scope", "module") |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
tests/test_fixtures.py
Outdated
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Hey @n1ngu, please have look again. Thanks |
There was a problem hiding this comment.
LGTM! Note I have no powers on this repo and can't merge nor even trigger the workflows. Let's see if we can draw the attention of a real maintainer.
@Luminaar @augi sorry to bother you: it seems that the pytest-docker community is interested in this feature. @austinkeller @gipi @BetterCallBene and me tried our best to get this done, if you kindly give it a look IMHO the present PR is ready to go.
My only remaining concern would be the 8 commits drift so I'd advise a squash+merge.
Thanks!
Resolves #89