metrics for signature-aggregator #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feuGeneA
force-pushed
the
signature-aggregation-api-metrics
branch
3 times, most recently
from
0013040
to
40028cc
Compare
feuGeneA
force-pushed
the
signature-aggregation-api-metrics
branch
from
40028cc
to
f1392e9
Compare
feuGeneA
requested review from
iansuvak,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
Signed-off-by: F. Eugene Aumson <[email protected]>
…signature-aggregation-api-metrics
…signature-aggregation-api-metrics
iansuvak
reviewed
Aug 5, 2024
| @@ -101,6 +105,7 @@ func (s *SignatureAggregator) AggregateSignaturesAppRequest( | |||
| zap.String("warpMessageID", unsignedMessage.ID().String()), | |||
| zap.Error(err), | |||
| ) | |||
| s.metrics.ValidatorFailures.Inc() | |||
There was a problem hiding this comment.
We probably want to distinguish between issues for more specific alerting. I.e. not connecting to validators is a broader issue than not being able to connect to sufficient stake and is very different from an individual validator not returning a valid signature response
There was a problem hiding this comment.
addressed in eb2e526
…signature-aggregation-api-metrics
addresses review comment #398 (comment)
cam-schultz
reviewed
Aug 6, 2024
…signature-aggregation-api-metrics
addresses review comment #398 (comment)
addresses review comment #398 (comment)
addresses review comment #398 (comment)
geoff-vball
previously approved these changes
Aug 7, 2024
cam-schultz
previously approved these changes
Aug 7, 2024
…pi-metrics Signed-off-by: F. Eugene Aumson <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iansuvak
dismissed stale reviews from cam-schultz and geoff-vball
The base branch was changed.
cam-schultz
approved these changes
Aug 9, 2024
geoff-vball
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
fixes #384
How this works
uses prometheus to publish an endpoint
How this was tested
Added metric value checks at the end of the existing signature aggregation test