Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Varios Fixes #739

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Varios Fixes #739

merged 7 commits into from
Oct 14, 2024

Conversation

felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Oct 11, 2024 •
edited
Loading

No description provided.

arturrez
arturrez reviewed Oct 11, 2024
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
arturrez
arturrez reviewed Oct 11, 2024
View reviewed changes
local/blockchain.go Outdated Show resolved Hide resolved
arturrez
arturrez reviewed Oct 11, 2024
View reviewed changes
local/network.go Outdated Show resolved Hide resolved
arturrez
arturrez reviewed Oct 11, 2024
View reviewed changes
server/network.go Outdated Show resolved Hide resolved
arturrez
arturrez reviewed Oct 11, 2024
View reviewed changes
local/network.go Outdated Show resolved Hide resolved
arturrez
arturrez reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@arturrez arturrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also tests are broken now

Base automatically changed from new-ids to main October 11, 2024 23:59
@felipemadero felipemadero requested a review from arturrez October 12, 2024 12:10
@felipemadero felipemadero merged commit 5bcdd0c into main Oct 14, 2024
6 checks passed
@felipemadero felipemadero deleted the fixes branch October 14, 2024 18:45
@felipemadero felipemadero restored the fixes branch October 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturrez arturrez arturrez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipemadero @arturrez