Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(imu_corrector): add gyro_bias_estimator #70

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 25, 2023

Description

See autowarefoundation/autoware.universe#4729

Related links

See autowarefoundation/autoware.universe#4729

Tests performed

See autowarefoundation/autoware.universe#4729

Notes for reviewers

See autowarefoundation/autoware.universe#4729

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda marked this pull request as draft August 25, 2023 01:08
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kminoda kminoda enabled auto-merge (squash) August 28, 2023 02:02
@kminoda kminoda merged commit dbecad5 into main Aug 28, 2023
8 of 9 checks passed
@kminoda kminoda deleted the feat/imu_corrector/add_gyro_bias_validator branch August 28, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants