fix(autoware_lanelet2_map_validator): removed redundant appendIssues() #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
requested review from
anhnv3991,
soblin,
Motsu-san,
SakodaShintaro and
YamatoAndo
as code owners
YamatoAndo
approved these changes
Nov 12, 2024
TaikiYamada4
deleted the
fix/lanelet2_map_validator/remove_redundant_append_issues
branch
Kazunori-Nakajima
added a commit
to Kazunori-Nakajima/autoware_tools
that referenced
this pull request
Nov 20, 2024
This reverts commit ac6ff25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the previous PR #147, I've put a bug that
appendIssues()will be executed twice. This PR removes the secondappendIssues().(Output screen with bug)
(Output screen without bug)
Related links
This PR #147 has a second
appendIssues()in the final part oflanelet::autoware::validation::validateMap()while the one before that PR #144 doesn't.Tests performed
Checked that redundant issues disappear from the console output as shown in the upper image.
Checked that
colcon testpassed.Notes for reviewers
This bug doesn't affect the JSON output but affects the output from
lanelet::validation::printAllIssues(issues);only.Interface changes
None
Effects on system behavior
Redundant console outputs no longer appear.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.