Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localize_topic): fix name-space organization of launch tree #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Owen-Liuyuxuan
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan commented Nov 1, 2024

Description

Fix name-space organization in launch tree.

  • Now we will manage group name-spaces and other name-spaces correctly.
  • Now the launch tree can separate same included launch files in different name-spaces.
  • However, The launch tree still can not identify multiple launch files in the same namespace.

Related links

Tests performed

It was tested in other projects that use more difficult launch files.

Notes for reviewers

Interface changes

None. Use the module as it is before is fine.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…nch file in different name-space

Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Owen-Liuyuxuan Owen-Liuyuxuan requested review from takayuki5168 and yhisaki and removed request for takayuki5168 November 7, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants