Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rviz): make it possible to set default topic name #140

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 30, 2024

Description

I fixed logic so that we can set default topic name in rviz config like this:

  - Class: tier4_string_viewer_rviz_plugin::StringViewerPanel
    Name: StringViewerPanel
    topic: /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/internal_state

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota enabled auto-merge (squash) October 31, 2024 00:25
@satoshi-ota satoshi-ota merged commit c634977 into main Oct 31, 2024
43 checks passed
@satoshi-ota satoshi-ota deleted the fix/string-viewer branch October 31, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants