Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_dummy_diag_publisher): add autowre prefix #9958

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

29a7f30
Select commit
Loading
Failed to load commit list.
Draft

fix(autoware_dummy_diag_publisher): add autowre prefix #9958

style(pre-commit): autofix
29a7f30
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 18, 2025 in 47s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.90 (10.00 -> 9.10)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Deep, Nested Complexity dummy_diag_publisher_core.cpp: DummyDiagPublisher::onSetParams
  • Complex Method dummy_diag_publisher_core.cpp: DummyDiagPublisher::onSetParams

Annotations

Check warning on line 201 in system/autoware_dummy_diag_publisher/src/dummy_diag_publisher_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

DummyDiagPublisher::onSetParams has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 201 in system/autoware_dummy_diag_publisher/src/dummy_diag_publisher_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

DummyDiagPublisher::onSetParams has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.