Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yolov10 node #9198

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

1e8a265
Select commit
Loading
Failed to load commit list.
Open

feat: add yolov10 node #9198

style(pre-commit): autofix
1e8a265
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 26, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: FAILED

Code Health of new files: 9.03

  • Declining Code Health: 6 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional tensorrt_yolov10_node.cpp: TrtYolov10Node::replaceLabelMap
  • Complex Method tensorrt_yolov10.cpp: TrtYolov10::TrtYolov10
  • Primitive Obsession tensorrt_yolov10.cpp
  • Complex Method tensorrt_yolov10_node.cpp: TrtYolov10Node::replaceLabelMap
  • Complex Conditional tensorrt_yolov10_node.cpp: TrtYolov10Node::onConnect
  • Bumpy Road Ahead tensorrt_yolov10.cpp: loadImageList

Annotations

Check warning on line 223 in perception/autoware_tensorrt_yolov10/src/tensorrt_yolov10.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

TrtYolov10::TrtYolov10 has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 107 in perception/autoware_tensorrt_yolov10/src/tensorrt_yolov10.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

loadImageList has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in perception/autoware_tensorrt_yolov10/src/tensorrt_yolov10.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Primitive Obsession

In this module, 54.5% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check warning on line 192 in perception/autoware_tensorrt_yolov10/src/tensorrt_yolov10_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

TrtYolov10Node::replaceLabelMap has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 79 in perception/autoware_tensorrt_yolov10/src/tensorrt_yolov10_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

TrtYolov10Node::onConnect has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 188 in perception/autoware_tensorrt_yolov10/src/tensorrt_yolov10_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

TrtYolov10Node::replaceLabelMap has 1 complex conditionals with 5 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.