fix(autoware_pointcloud_preprocessor): launch file load parameter from yaml #8129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
7 tasks
Signed-off-by: vividf <[email protected]>
vividf
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8129 +/- ##
==========================================
- Coverage 29.17% 29.00% -0.17%
==========================================
Files 1336 1733 +397
Lines 103038 126001 +22963
Branches 39954 54513 +14559
==========================================
+ Hits 30059 36545 +6486
- Misses 70031 80031 +10000
- Partials 2948 9425 +6477
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: vividf <[email protected]>
…thub.com:vividf/autoware.universe into feature/fix_pointcloud_preprocessor_launch_files
YoshiRi
reviewed
Sep 3, 2024
There was a problem hiding this comment.
[imho]
I think it's better to use launch_arguments.append(DeclareLaunchArgument(name, default_value=default_value)) to enable launch args so that user can give parameter file from outside of this launcher. (But you can do this in another PR.)
There was a problem hiding this comment.
Sorry for the late reply!
I understand your concern for consistency.
However, using that makes the launcher more complex than before (and 15 -20 lines more)
I would like to keep it for this PR. If it is really needed, let me work on it on another PR :)
Thanks!
There was a problem hiding this comment.
If it is really needed, let me work on it on another PR :)
I agree! Thanks for your reply!
vividf
changed the title
Signed-off-by: vividf <[email protected]>
YoshiRi
approved these changes
Nov 7, 2024
youtalk
added a commit
that referenced
this pull request
Nov 25, 2024
* chore: update CODEOWNERS (#9203) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> * refactor(time_utils): prefix package and namespace with autoware (#9173) * refactor(time_utils): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * refactor(time_utils): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(rtc_interface): add requested field (#9202) * add requested feature Signed-off-by: Go Sakayori <[email protected]> * Update planning/autoware_rtc_interface/test/test_rtc_interface.cpp Co-authored-by: Satoshi OTA <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Co-authored-by: Satoshi OTA <[email protected]> * fix(mpc_lateral_controller): correctly resample the MPC trajectory yaws (#9199) Signed-off-by: Maxime CLEMENT <[email protected]> * fix(bpp): prevent accessing nullopt (#9204) fix(bpp): calcDistanceToRedTrafficLight null Signed-off-by: Shumpei Wakabayashi <[email protected]> * refactor(autoware_map_based_prediction): split pedestrian and bicycle predictor (#9201) * refactor: grouping functions Signed-off-by: Taekjin LEE <[email protected]> * refactor: grouping parameters Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename member road_users_history to road_users_history_ Signed-off-by: Taekjin LEE <[email protected]> * refactor: separate util functions Signed-off-by: Taekjin LEE <[email protected]> * refactor: Add predictor_vru.cpp and utils.cpp to map_based_prediction_node Signed-off-by: Taekjin LEE <[email protected]> * refactor: Add explicit template instantiation for removeOldObjectsHistory function Signed-off-by: Taekjin LEE <[email protected]> * refactor: Add tf2_geometry_msgs to data_structure Signed-off-by: Taekjin LEE <[email protected]> * refactor: Remove unused variables and functions in map_based_prediction_node.cpp Signed-off-by: Taekjin LEE <[email protected]> * Update perception/autoware_map_based_prediction/include/map_based_prediction/predictor_vru.hpp * Apply suggestions from code review * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: Mamoru Sobue <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(ndt_scan_matcher, ndt_omp): move ndt_omp into ndt_scan_matcher (#8912) * Moved ndt_omp into ndt_scan_matcher Signed-off-by: Shintaro Sakoda <[email protected]> * Added Copyright Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Fixed include Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed cast style Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed include Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed honorific title Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed honorific title Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Fixed include hierarchy Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Fixed include hierarchy Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Fixed hierarchy Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed NVTP to NVTL Signed-off-by: Shintaro Sakoda <[email protected]> * Added cspell:ignore Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed miss spell Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Fixed include Signed-off-by: Shintaro Sakoda <[email protected]> * Renamed applyFilter Signed-off-by: Shintaro Sakoda <[email protected]> * Moved ***_impl.hpp from include/ to src/ Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Fixed variable scope Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed to pass by reference Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_test_utils): add traffic light msgs parser (#9177) Signed-off-by: Mamoru Sobue <[email protected]> * fix(rtc_interface): update requested field for every cooperateStatus state (#9211) * fix rtc_interface Signed-off-by: Go Sakayori <[email protected]> * fix test condition Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> * feat(static_obstacle_avoidance): operator request for ambiguous vehicle (#9205) * add operator request feature Signed-off-by: Go Sakayori <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/scene.cpp Co-authored-by: Satoshi OTA <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Co-authored-by: Satoshi OTA <[email protected]> * feat(collision_detector): use polling subscriber (#9213) use polling subscriber Signed-off-by: Go Sakayori <[email protected]> * fix(diagnostic_graph_utils): reset graph when new one is received (#9208) fix(diagnostic_graph_utils): reset graph when new one is reveived Signed-off-by: Takagi, Isamu <[email protected]> * fix(autoware_ndt_scan_matcher): reduce initial_pose_estimation.particles_num from 200 to 100 on tests (#9218) Reduced initial_pose_estimation.particles_num from 200 to 100 on tests Signed-off-by: Shintaro Sakoda <[email protected]> * feat(control_launch): add collision detector in launch (#9214) add collision detector in launch Signed-off-by: Go Sakayori <[email protected]> * chore(obstacle_cruise_planner): add function tests for a utils function (#9206) * add utils test --------- Signed-off-by: Yuki Takagi <[email protected]> * fix(bvp): remove expired module safely (#9212) * fix(bvp): remove expired module safely Signed-off-by: satoshi-ota <[email protected]> * fix: remove module id set Signed-off-by: satoshi-ota <[email protected]> * fix: use itr to erase expired module Signed-off-by: satoshi-ota <[email protected]> * fix: remove unused function Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> * test(bpp_common): add unit test for safety check (#9223) * add test for object collision Signed-off-by: Go Sakayori <[email protected]> * add test for more functions Signed-off-by: Go Sakayori <[email protected]> * add docstring Signed-off-by: Go Sakayori <[email protected]> * fix lane change Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]> * fix(autoware_behavior_path_goal_planner_module): fix cppcheck unreadVariable (#9192) Signed-off-by: Ryuta Kambe <[email protected]> * fix(autoware_image_projection_based_fusion): fix bugprone-misplaced-widening-cast (#9229) * fix: bugprone-misplaced-widening-cast Signed-off-by: kobayu858 <[email protected]> * fix: clang-format Signed-off-by: kobayu858 <[email protected]> --------- Signed-off-by: kobayu858 <[email protected]> * fix(autoware_euclidean_cluster): fix bugprone-misplaced-widening-cast (#9227) fix: bugprone-misplaced-widening-cast Signed-off-by: kobayu858 <[email protected]> * fix(autoware_image_projection_based_fusion): fix bugprone-misplaced-widening-cast (#9226) * fix: bugprone-misplaced-widening-cast Signed-off-by: kobayu858 <[email protected]> * fix: clang-format Signed-off-by: kobayu858 <[email protected]> --------- Signed-off-by: kobayu858 <[email protected]> * fix(autoware_compare_map_segmentation): fix cppcheck constVariableReference (#9196) Signed-off-by: Ryuta Kambe <[email protected]> * refactor(component_interface_utils): prefix package and namespace with autoware (#9092) Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_behavior_velocity_no_stopping_area_module): fix cppcheck knownConditionTrueFalse (#9189) Signed-off-by: Ryuta Kambe <[email protected]> * fix(autoware_freespace_planning_algorithms): fix bugprone-unused-raii (#9230) fix: bugprone-unused-raii Signed-off-by: kobayu858 <[email protected]> * refactor(map_based_prediction): divide objectsCallback (#9219) Signed-off-by: Mamoru Sobue <[email protected]> * refactor(map_based_prediction): move member functions to utils (#9225) Signed-off-by: Mamoru Sobue <[email protected]> * test(crosswalk): add unit test (#9228) Signed-off-by: Yuki Takagi <[email protected]> * fix(autoware_probabilistic_occupancy_grid_map): fix bugprone-incorrect-roundings (#9221) fix: bugprone-incorrect-roundings Signed-off-by: kobayu858 <[email protected]> * refactor(cuda_utils): prefix package and namespace with autoware (#9171) Signed-off-by: Esteve Fernandez <[email protected]> * fix(crosswalk): don't use vehicle stop checker to remove unnecessary callback (#9234) Signed-off-by: satoshi-ota <[email protected]> * feat(autoware_motion_utils): add new trajectory class (#8693) * feat(autoware_motion_utils): add interpolator Signed-off-by: Y.Hisaki <[email protected]> * use int32_t instead of int Signed-off-by: Y.Hisaki <[email protected]> * use int32_t instead of int Signed-off-by: Y.Hisaki <[email protected]> * use int32_t instead of int Signed-off-by: Y.Hisaki <[email protected]> * add const as much as possible and use `at()` in `vector` Signed-off-by: Y.Hisaki <[email protected]> * fix directory name Signed-off-by: Y.Hisaki <[email protected]> * refactor code and add example Signed-off-by: Y.Hisaki <[email protected]> * update Signed-off-by: Y.Hisaki <[email protected]> * remove unused include Signed-off-by: Y.Hisaki <[email protected]> * refactor code Signed-off-by: Y.Hisaki <[email protected]> * add clone function Signed-off-by: Y.Hisaki <[email protected]> * fix stairstep Signed-off-by: Y.Hisaki <[email protected]> * make constructor to public Signed-off-by: Y.Hisaki <[email protected]> * feat(autoware_motion_utils): add trajectory class Signed-off-by: Y.Hisaki <[email protected]> * Update CMakeLists.txt * fix Signed-off-by: Y.Hisaki <[email protected]> * fix package.xml Signed-off-by: Y.Hisaki <[email protected]> * update crop Signed-off-by: Y.Hisaki <[email protected]> * revert crtp change Signed-off-by: Y.Hisaki <[email protected]> * update package.xml Signed-off-by: Y.Hisaki <[email protected]> * updating... Signed-off-by: Y.Hisaki <[email protected]> * update Signed-off-by: Y.Hisaki <[email protected]> * solve build problem Signed-off-by: Y.Hisaki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Y.Hisaki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(autoware_image_projection_based_fusion): make optional to consider lens distortion in the point projection (#9233) chore: add point_project_to_unrectified_image parameter to fusion_common.param.yaml Signed-off-by: Taekjin LEE <[email protected]> * feat(autoware_test_utils): add general topic dumper (#9207) Signed-off-by: Mamoru Sobue <[email protected]> * fix(autoware_ekf_localizer): remove `timer_tf_` (#9244) Removed timer_tf_ Signed-off-by: Shintaro Sakoda <[email protected]> * fix(autoware_rtc_interface): fix dependency (#9237) Signed-off-by: Esteve Fernandez <[email protected]> * fix(autonomous_emergency_braking): solve issue with arc length (#9247) * solve issue with arc length Signed-off-by: Daniel Sanchez <[email protected]> * fix problem with points one vehicle apart from path Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * fix(autoware_lidar_apollo_instance_segmentation): fix cppcheck suspiciousFloatingPointCast (#9195) Signed-off-by: Ryuta Kambe <[email protected]> * fix(autoware_behavior_path_sampling_planner_module): fix cppcheck unusedVariable (#9190) Signed-off-by: Ryuta Kambe <[email protected]> * refactor(qp_interface): prefix package and namespace with autoware (#9236) Signed-off-by: Esteve Fernandez <[email protected]> * chore(autoware_geography_utils): update maintainers (#9246) * update maintainers Signed-off-by: Yamato Ando <[email protected]> * add author Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> * fix(lane_change): enable cancel when ego in turn direction lane (#9124) * RT0-33893 add checks from prev intersection Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]> * fix shadow variable Signed-off-by: Zulfaqar Azmi <[email protected]> * fix logic Signed-off-by: Zulfaqar Azmi <[email protected]> * update readme Signed-off-by: Zulfaqar Azmi <[email protected]> * refactor get_ego_footprint Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]> * fix(out_of_lane): correct calculations of the stop pose (#9209) Signed-off-by: Maxime CLEMENT <[email protected]> * fix(autoware_pointcloud_preprocessor): launch file load parameter from yaml (#8129) * feat: fix launch file Signed-off-by: vividf <[email protected]> * chore: fix spell error Signed-off-by: vividf <[email protected]> * chore: fix parameters file name Signed-off-by: vividf <[email protected]> * chore: remove filter base Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> * fix: missing dependency in common components (#9072) * feat(autoware_trajectory): move trajectory_container from autoware_motion_utils to a new package (#9253) * create trajectory container package Signed-off-by: Y.Hisaki <[email protected]> * update Signed-off-by: Y.Hisaki <[email protected]> * update Signed-off-by: Y.Hisaki <[email protected]> * style(pre-commit): autofix * update codeowner Signed-off-by: Y.Hisaki <[email protected]> * update Signed-off-by: Y.Hisaki <[email protected]> * fix cmake Signed-off-by: Y.Hisaki <[email protected]> --------- Signed-off-by: Y.Hisaki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(autoware_pointcloud_preprocessor): fix the wrong naming of crop box parameter file (#9258) fix: fix the wrong file name Signed-off-by: vividf <[email protected]> * fix(dummy_diag_publisher): not use diagnostic_updater and param callback (#9257) * fix(dummy_diag_publisher): not use diagnostic_updater and param callback for v0.29.0 (#1414) fix(dummy_diag_publisher): not use diagnostic_updater and param callback Co-authored-by: h-ohta <[email protected]> * fix: resolve build error of dummy diag publisher (#1415) fix merge conflict --------- Co-authored-by: Shohei Sakai <[email protected]> Co-authored-by: h-ohta <[email protected]> * test(behavior_path_planner_common): add unit test for path shifter (#9239) * add unit test for path shifter Signed-off-by: Go Sakayori <[email protected]> * fix unnecessary modification Signed-off-by: Go Sakayori <[email protected]> * fix spelling mistake Signed-off-by: Go Sakayori <[email protected]> * add docstring Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]> * feat(system_monitor): support loopback network interface (#9067) * feat(system_monitor): support loopback network interface Signed-off-by: takeshi.iwanari <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_trajectory): change interface of InterpolatedArray (#9264) change interface of InterpolateArray Signed-off-by: Y.Hisaki <[email protected]> * feat(system_monitor): add on/off config for network traffic monitor (#9069) * feat(system_monitor): add config for network traffic monitor Signed-off-by: takeshi.iwanari <[email protected]> * fix: change function name from stop to skip Signed-off-by: takeshi.iwanari <[email protected]> --------- Signed-off-by: takeshi.iwanari <[email protected]> * feat(detection_area)!: add retruction feature (#9255) Signed-off-by: Yuki Takagi <[email protected]> * fix(vehicle_cmd_gate): fix processing time measurement (#9260) Signed-off-by: Maxime CLEMENT <[email protected]> * fix(bvp): use polling subscriber (#9242) * fix(bvp): use polling subscriber Signed-off-by: satoshi-ota <[email protected]> * fix: use newest policy Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> * refactor(lane_change): remove std::optional from lanes polygon (#9267) Signed-off-by: Zulfaqar Azmi <[email protected]> * fix(bpp): prevent accessing nullopt (#9269) Signed-off-by: Shumpei Wakabayashi <[email protected]> * refactor(lane_change): revert "remove std::optional from lanes polygon" (#9272) Revert "refactor(lane_change): remove std::optional from lanes polygon (#9267)" This reverts commit 0c70ea8. * feat(goal_planner): sort candidate path only when num to avoid is different (#9271) Signed-off-by: kosuke55 <[email protected]> * fix(/autoware_freespace_planning_algorithms): fix cppcheck unusedFunction (#9274) Signed-off-by: Ryuta Kambe <[email protected]> * fix(autoware_behavior_path_start_planner_module): fix cppcheck unreadVariable (#9277) Signed-off-by: Ryuta Kambe <[email protected]> * fix(autoware_ndt_scan_matcher): fix cppcheck unusedFunction (#9275) Signed-off-by: Ryuta Kambe <[email protected]> * fix(autoware_pure_pursuit): fix cppcheck unusedFunction (#9276) Signed-off-by: Ryuta Kambe <[email protected]> * fix(lane_change): correct computation of maximum lane changing length threshold (#9279) fix computation of maximum lane changing length threshold Signed-off-by: mohammad alqudah <[email protected]> * feat(aeb): set global param to override autoware state check (#9263) * set global param to override autoware state check Signed-off-by: Daniel Sanchez <[email protected]> * change variable to be more general Signed-off-by: Daniel Sanchez <[email protected]> * add comment Signed-off-by: Daniel Sanchez <[email protected]> * move param to control component launch Signed-off-by: Daniel Sanchez <[email protected]> * change param name to be more straightforward Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> * fix(autoware_default_adapi): change subscribing steering factor topic name for obstacle avoidance and lane changes (#9273) feat(planning): add new steering factor topics for obstacle avoidance and lane changes Signed-off-by: kyoichi-sugahara <[email protected]> * chore(package.xml): bump version to 0.38.0 (#9266) (#9284) * unify package.xml version to 0.37.0 * remove system_monitor/CHANGELOG.rst * add changelog * 0.38.0 --------- Signed-off-by: Yutaka Kondo <[email protected]> * fix(lane_change): extending lane change path for multiple lane change (RT1-8427) (#9268) * RT1-8427 extending lc path for multiple lc Signed-off-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp Co-authored-by: mkquda <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Co-authored-by: mkquda <[email protected]> * fix(autoware_utils): address self-intersecting polygons in random_concave_generator and handle empty inners() during triangulation (#8995) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <[email protected]> * fix(behavior_path_planner_common): use boost intersects instead of overlaps (#9289) * fix(behavior_path_planner_common): use boost intersects instead of overlaps Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_safety_checker/safety_check.cpp Co-authored-by: Go Sakayori <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Go Sakayori <[email protected]> * ci(.github): update image tags (#9286) * refactor(autoware_ad_api_specs): prefix package and namespace with autoware (#9250) * refactor(autoware_ad_api_specs): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * chore(autoware_adapi_specs): rename ad_api to adapi Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * chore(autoware_adapi_specs): rename ad_api to adapi Signed-off-by: Esteve Fernandez <[email protected]> * chore(autoware_adapi_specs): rename ad_api to adapi Signed-off-by: Esteve Fernandez <[email protected]> * chore(autoware_adapi_specs): rename ad_api_specs to adapi_specs Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore(autoware_traffic_light*): add maintainer (#9280) * add fundamental commit Signed-off-by: MasatoSaeki <[email protected]> * add forgot package Signed-off-by: MasatoSaeki <[email protected]> --------- Signed-off-by: MasatoSaeki <[email protected]> * fix(autoware_mpc_lateral_controller): fix bugprone-misplaced-widening-cast (#9224) * fix: bugprone-misplaced-widening-cast Signed-off-by: kobayu858 <[email protected]> * fix: consider negative values Signed-off-by: kobayu858 <[email protected]> --------- Signed-off-by: kobayu858 <[email protected]> * fix(autoware_detected_object_validation): fix clang-diagnostic-error (#9215) fix: clang-c-error Signed-off-by: kobayu858 <[email protected]> * fix(autoware_detected_object_validation): fix bugprone-incorrect-roundings (#9220) fix: bugprone-incorrect-roundings Signed-off-by: kobayu858 <[email protected]> * feat(autoware_test_utils): use sample_vehicle/sample_sensor_kit (#9290) Signed-off-by: Mamoru Sobue <[email protected]> * refactor(lane_change): remove std::optional from lanes polygon (#9288) Signed-off-by: Zulfaqar Azmi <[email protected]> * feat(tier4_metric_msgs): apply tier4_metric_msgs for scenario_simulator_v2_adapter, control_evaluator, planning_evaluator, autonomous_emergency_braking, obstacle_cruise_planner, motion_velocity_planner, processing_time_checker (#9180) * first commit Signed-off-by: xtk8532704 <[email protected]> * fix building errs. Signed-off-by: xtk8532704 <[email protected]> * change diagnostic messages to metric messages for publishing decision. Signed-off-by: xtk8532704 <[email protected]> * fix bug about motion_velocity_planner Signed-off-by: xtk8532704 <[email protected]> * change the diagnostic msg to metric msg in autoware_obstacle_cruise_planner. Signed-off-by: xtk8532704 <[email protected]> * tmp save for planning_evaluator Signed-off-by: xtk8532704 <[email protected]> * change the topic to which metrics published to. Signed-off-by: xtk8532704 <[email protected]> * fix typo. Signed-off-by: xtk8532704 <[email protected]> * remove unnesessary publishing of metrics. Signed-off-by: xtk8532704 <[email protected]> * mke planning_evaluator publish msg of MetricArray instead of Diags. Signed-off-by: xtk8532704 <[email protected]> * update aeb with metric type for decision. Signed-off-by: xtk8532704 <[email protected]> * fix some bug Signed-off-by: xtk8532704 <[email protected]> * remove autoware_evaluator_utils package. Signed-off-by: xtk8532704 <[email protected]> * remove diagnostic_msgs dependency of planning_evaluator Signed-off-by: xtk8532704 <[email protected]> * use metric_msgs for autoware_processing_time_checker. Signed-off-by: xtk8532704 <[email protected]> * rewrite diagnostic_convertor to scenario_simulator_v2_adapter, supporting metric_msgs. Signed-off-by: xtk8532704 <[email protected]> * pre-commit and fix typo Signed-off-by: xtk8532704 <[email protected]> * publish metrics even if there is no metric in the MetricArray. Signed-off-by: xtk8532704 <[email protected]> * modify the metric name of processing_time. Signed-off-by: xtk8532704 <[email protected]> * update unit test for test_planning/control_evaluator Signed-off-by: xtk8532704 <[email protected]> * manual pre-commit Signed-off-by: xtk8532704 <[email protected]> --------- Signed-off-by: xtk8532704 <[email protected]> * feat(diagnostic_graph_aggregator): implement diagnostic graph dump functionality (#9261) Signed-off-by: Takagi, Isamu <[email protected]> * chore(tvm_utility): remove tvm_utility package as it is no longer used (#9291) Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix ticket links to point to https://github.com/autowarefoundation/autoware.universe (#9304) Signed-off-by: Esteve Fernandez <[email protected]> * perf(autoware_ndt_scan_matcher): remove evecs_, evals_ of Leaf for memory efficiency (#9281) * fix(lane_change): correct computation of maximum lane changing length threshold (#9279) fix computation of maximum lane changing length threshold Signed-off-by: mohammad alqudah <[email protected]> Signed-off-by: taisa1 <[email protected]> * perf: remove evecs, evals from Leaf Signed-off-by: taisa1 <[email protected]> * perf: remove evecs, evals from Leaf Signed-off-by: taisa1 <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Signed-off-by: taisa1 <[email protected]> Co-authored-by: mkquda <[email protected]> * test(costmap_generator): unit test implementation for costmap generator (#9149) * modify costmap generator directory structure Signed-off-by: mohammad alqudah <[email protected]> * rename class CostmapGenerator to CostmapGeneratorNode Signed-off-by: mohammad alqudah <[email protected]> * unit test for object_map_utils Signed-off-by: mohammad alqudah <[email protected]> * catch error from lookupTransform Signed-off-by: mohammad alqudah <[email protected]> * use polling subscriber in costmap generator node Signed-off-by: mohammad alqudah <[email protected]> * add test for costmap generator node Signed-off-by: mohammad alqudah <[email protected]> * add test for isActive() Signed-off-by: mohammad alqudah <[email protected]> * revert unnecessary changes Signed-off-by: mohammad alqudah <[email protected]> * remove commented out line Signed-off-by: mohammad alqudah <[email protected]> * minor fix Signed-off-by: mohammad alqudah <[email protected]> * Update planning/autoware_costmap_generator/src/costmap_generator.cpp Co-authored-by: Kosuke Takeuchi <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]> * fix(control): missing dependency in control components (#9073) * test(autoware_control_evaluator): add unit test for utils autoware_control_evaluator (#9307) * update unit test of control_evaluator. Signed-off-by: xtk8532704 <[email protected]> * manual pre-commit. Signed-off-by: xtk8532704 <[email protected]> --------- Signed-off-by: xtk8532704 <[email protected]> * fix(collision_detector): skip process when odometry is not published (#9308) * subscribe odometry Signed-off-by: Go Sakayori <[email protected]> * fix precommit Signed-off-by: Go Sakayori <[email protected]> * remove unnecessary log info Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> * feat(goal_planner): safety check with only parking path (#9293) Signed-off-by: kosuke55 <[email protected]> * refactor(goal_planner): remove reference_goal_pose getter/setter (#9270) Signed-off-by: Mamoru Sobue <[email protected]> * feat(start_planner, lane_departure_checker): speed up by updating polygons (#9309) speed up by updating polygons Signed-off-by: Daniel Sanchez <[email protected]> * fix(autoware_trajectory): fix bug of autoware_trajectory (#9314) Signed-off-by: Y.Hisaki <[email protected]> * feat(autoware_trajectory): change default value of min_points (#9315) Signed-off-by: Y.Hisaki <[email protected]> * chore(codecov): update maintained packages (#9316) Signed-off-by: Mamoru Sobue <[email protected]> * doc: fix links to design documents (#9301) Signed-off-by: Esteve Fernandez <[email protected]> * fix(costmap_generator): use vehicle frame for lidar height thresholds (#9311) Signed-off-by: Maxime CLEMENT <[email protected]> * fix(tier4_dummy_object_rviz_plugin): fix missing dependency (#9306) Signed-off-by: Esteve Fernandez <[email protected]> * fix: fix ticket links to point to https://github.com/autowarefoundation/autoware.universe (#9304) Signed-off-by: Esteve Fernandez <[email protected]> * add changelog Signed-off-by: Yutaka Kondo <[email protected]> * update changelog Signed-off-by: Yutaka Kondo <[email protected]> * fix version Signed-off-by: Yutaka Kondo <[email protected]> * 0.39.0 * refactor(map_loader)!: prefix package and namespace with autoware (#8927) * make lanelet2_map_visualization independent Signed-off-by: a-maumau <[email protected]> * remove unused files Signed-off-by: a-maumau <[email protected]> * remove unused package Signed-off-by: a-maumau <[email protected]> * fix package name Signed-off-by: a-maumau <[email protected]> * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * add autoware to exec name Signed-off-by: a-maumau <[email protected]> * add autoware prefix Signed-off-by: a-maumau <[email protected]> * removed unnecessary dependency Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> * update version Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Shumpei Wakabayashi <[email protected]> Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: kobayu858 <[email protected]> Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: Y.Hisaki <[email protected]> Signed-off-by: Daniel Sanchez <[email protected]> Signed-off-by: Yamato Ando <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: mohammad alqudah <[email protected]> Signed-off-by: kyoichi-sugahara <[email protected]> Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: MasatoSaeki <[email protected]> Signed-off-by: xtk8532704 <[email protected]> Signed-off-by: taisa1 <[email protected]> Signed-off-by: a-maumau <[email protected]> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> Co-authored-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Go Sakayori <[email protected]> Co-authored-by: Satoshi OTA <[email protected]> Co-authored-by: Maxime CLEMENT <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: Taekjin LEE <[email protected]> Co-authored-by: Mamoru Sobue <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Yuki TAKAGI <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]> Co-authored-by: kobayu858 <[email protected]> Co-authored-by: Yukinari Hisaki <[email protected]> Co-authored-by: danielsanchezaran <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]> Co-authored-by: ぐるぐる <[email protected]> Co-authored-by: Shohei Sakai <[email protected]> Co-authored-by: h-ohta <[email protected]> Co-authored-by: iwatake <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]> Co-authored-by: mkquda <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: Giovanni Muhammad Raditya <[email protected]> Co-authored-by: Masato Saeki <[email protected]> Co-authored-by: Kem (TiankuiXian) <[email protected]> Co-authored-by: Kento Osa <[email protected]> Co-authored-by: Masaki Baba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #8509, #8300, and #8466 replace default parameters by using parameter schema and parameter yaml file in the pointcloud preprocessor.
This PR enables the launcher to load the parameter from yaml file.
Note that this PR should be merged after all of the PRs mentioned above are merged.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.