Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnss_poser): remove plane coordinate #4711

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 22, 2023

Description

Remove plane coordinate. Please see the discussion for details: https://github.com/orgs/autowarefoundation/discussions/3759

Related links

https://github.com/orgs/autowarefoundation/discussions/3759

Merge with autowarefoundation/sample_sensor_kit_launch#68

Tests performed

  • Confirmed that logging simulator tutorial works fine.
  • Searched with geo_pos_conv and confirmed that there is no such terms left in autoware.universe except CODEOWNERS

Notes for reviewers

None

Interface changes

None

Effects on system behavior

Plane (平面直角座標系) coordinate system will not be supported any longer. We conducted a survey and confirmed that there is possibly no users that may be affected by this PR.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Aug 22, 2023
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2023
@kminoda kminoda marked this pull request as ready for review August 23, 2023 07:17
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (9407021) 14.88% compared to head (b07a7ba) 14.90%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4711      +/-   ##
==========================================
+ Coverage   14.88%   14.90%   +0.02%     
==========================================
  Files        1549     1549              
  Lines      107005   106755     -250     
  Branches    32808    32713      -95     
==========================================
- Hits        15925    15910      -15     
+ Misses      73683    73453     -230     
+ Partials    17397    17392       -5     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.90% <ø> (+0.02%) ⬆️ Carriedforward from 9b1e4e3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp 68.08% <ø> (-3.35%) ⬇️
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 75.00% <ø> (-2.78%) ⬇️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.29% <ø> (+0.01%) ⬆️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...icle_cmd_gate/test/src/test_vehicle_cmd_filter.cpp 70.83% <ø> (+0.16%) ⬆️
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 9.09% <ø> (+0.16%) ⬆️
...ap_projection_loader/src/map_projection_loader.cpp 26.92% <ø> (-1.65%) ⬇️
...obabilistic_occupancy_grid_map/src/utils/utils.cpp 48.52% <ø> (+1.38%) ⬆️
...ude/freespace_planning_algorithms/astar_search.hpp 87.50% <ø> (ø)
sensing/gnss_poser/include/gnss_poser/convert.hpp 0.00% <ø> (ø)
... and 5 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit a69ee45 into autowarefoundation:main Aug 23, 2023
40 of 42 checks passed
@kminoda kminoda deleted the feat/gnss_poser/remove_plane branch September 26, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants