-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnss_poser): remove plane coordinate #4711
Merged
kminoda
merged 4 commits into
autowarefoundation:main
from
kminoda:feat/gnss_poser/remove_plane
Aug 23, 2023
Merged
feat(gnss_poser): remove plane coordinate #4711
kminoda
merged 4 commits into
autowarefoundation:main
from
kminoda:feat/gnss_poser/remove_plane
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
labels
Aug 22, 2023
kminoda
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 23, 2023
4 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4711 +/- ##
==========================================
+ Coverage 14.88% 14.90% +0.02%
==========================================
Files 1549 1549
Lines 107005 106755 -250
Branches 32808 32713 -95
==========================================
- Hits 15925 15910 -15
+ Misses 73683 73453 -230
+ Partials 17397 17392 -5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
YamatoAndo
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove plane coordinate. Please see the discussion for details: https://github.com/orgs/autowarefoundation/discussions/3759
Related links
https://github.com/orgs/autowarefoundation/discussions/3759
Merge with autowarefoundation/sample_sensor_kit_launch#68
Tests performed
geo_pos_conv
and confirmed that there is no such terms left in autoware.universe except CODEOWNERSNotes for reviewers
None
Interface changes
None
Effects on system behavior
Plane (平面直角座標系) coordinate system will not be supported any longer. We conducted a survey and confirmed that there is possibly no users that may be affected by this PR.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.