Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update domain config items #3083

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Update domain config items #3083

merged 7 commits into from
Oct 4, 2024

Conversation

NingLin-P
Copy link
Member

This PR implements subspace/protocol-specs#22, includes changes of:

  • Remove the unused DomainConfig::target_bundles_per_block field
  • Replace DomainConfig::max_block_size/weight with DomainConfig::max_bundle_size/weight
  • Recorrect the max domain extrinsic weight in the domain runtime

Code contributor checklist:

teor2345
teor2345 reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks reasonable to me, but I think someone more familiar should double-check.

crates/pallet-domains/src/tests.rs Outdated Show resolved Hide resolved
crates/pallet-domains/src/tests.rs Outdated Show resolved Hide resolved
dariolina
dariolina reviewed Oct 2, 2024
View reviewed changes
crates/subspace-malicious-operator/src/chain_spec.rs Outdated
max_bundle_weight,
} = calculate_max_bundle_weight_and_size(
MaxDomainBlockSize::get(),
MaxDomainBlockWeight::get(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not MAX right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is not a hard limit for the domain block (which is set to MAX in the domain runtime), it is used as hard limit for the bundle weight/size though.

crates/subspace-node/src/chain_spec.rs Outdated Show resolved Hide resolved
@NingLin-P NingLin-P added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 950df0b Oct 4, 2024
9 checks passed
@NingLin-P NingLin-P deleted the bundle-config branch October 4, 2024 10:22
@NingLin-P NingLin-P mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 left review comments

@dariolina dariolina dariolina approved these changes

@dastansam dastansam Awaiting requested review from dastansam

@nazar-pc nazar-pc Awaiting requested review from nazar-pc nazar-pc is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NingLin-P @teor2345 @dariolina