-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument types to be able to use torch JIT #54
base: master
Are you sure you want to change the base?
Conversation
@AdrianEddy Thank you for great works! Traceback (most recent call last): |
@ylab604 Please check now |
I see i did change the mask function when i check your code(yesterday). |
Anyway thank you for your kindness. And i will also update the result of excution |
What do you mean it's not normal? What's weird about it? |
This means that if converted to onnx or jit, the inference output will be different from the original torch model. |
This PR adds types to function signatures to be able to use
torch.jit
ortorch.onnx.export()
. I also had to convert some functions to modulesThe code should be equivalent to the previous one, I verified that with inference (I didn't test training though)
It's easiest to review this without whitespace diff
Related to #29