Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): filelock issues #161

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Conversation

eddiebergman
Copy link
Contributor

Fixes issues with larger scale runs of NePS.

  1. A condition that was expected but there was a local variable not defined error which fixes issues for multiple worker contention.
  2. Reporting a trial no longer needs to lock the optimizer state, instead the values for budget are computed directly during the sampling procedure, where the lock and trials are already loaded in.
  3. Allow retring or creating/loading the NePS state, as there is no locking mechanism that will work reliably, until the directory is fully created. e.g. Imagine 100 workers all thinking they're the first and trying to create the directory at once.

This means that reporting a trial value no longer has to lock the
optimizers state, as this will now be computed when sampling a
new trial, given we have access to all the trials and the optimizer
state at this point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant