Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible PyTorch implementation of WL kernel #153
base: master
Are you sure you want to change the base?
Possible PyTorch implementation of WL kernel #153
Changes from 9 commits
36fc3bd
b0d3842
f87abd6
358fbb7
de140b6
08c7aea
6f07858
896f461
383e924
65666a3
7fa9432
4227f22
f194bd2
a104840
246f9f6
770c626
8bf7ea7
84d0104
d63239a
3db3f89
f69ddbe
1c4cc83
dab9a8c
2999582
ad55030
8093d31
9f978d6
a1a29a8
046ad66
0a609f7
5486dcc
f140c56
371b530
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing there's no way to really make it such that we could pass the
TorchWLKernel
to theAdditiveKernel
, i.e. you would use it just like any other kernel type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could define a
WLKernel
class that extendsgpytorch.kernels.Kernel
and use that class instead ofTorchWLKernel
.