Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sobol sequence #729 #731

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix sobol sequence #729 #731

merged 2 commits into from
Jul 16, 2021

Conversation

benjamc
Copy link
Collaborator

@benjamc benjamc commented Jul 16, 2021

Fixes this issue: #729

But now scipy needs to be >= 1.7.0 --> Update requirements?

@benjamc benjamc requested a review from renesass July 16, 2021 08:42
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #731 (1c79202) into development (0677f30) will increase coverage by 66.97%.
The diff coverage is 100.00%.

❗ Current head 1c79202 differs from pull request most recent head ead7e3c. Consider uploading reports for the commit ead7e3c to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           development     #731       +/-   ##
================================================
+ Coverage        19.84%   86.81%   +66.97%     
================================================
  Files               68       68               
  Lines             6143     6144        +1     
================================================
+ Hits              1219     5334     +4115     
+ Misses            4924      810     -4114     
Impacted Files Coverage Δ
smac/initial_design/sobol_design.py 94.73% <100.00%> (+83.62%) ⬆️
smac/epm/base_imputor.py 100.00% <0.00%> (+7.69%) ⬆️
smac/tae/__init__.py 100.00% <0.00%> (+17.24%) ⬆️
smac/configspace/util.py 100.00% <0.00%> (+20.00%) ⬆️
smac/optimizer/random_configuration_chooser.py 69.23% <0.00%> (+25.27%) ⬆️
...mac/initial_design/default_configuration_design.py 100.00% <0.00%> (+27.27%) ⬆️
smac/utils/logging.py 81.48% <0.00%> (+29.62%) ⬆️
smac/epm/random_epm.py 85.18% <0.00%> (+33.33%) ⬆️
smac/tae/serial_runner.py 96.00% <0.00%> (+36.00%) ⬆️
smac/utils/merge_foreign_data.py 60.00% <0.00%> (+40.00%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0677f30...ead7e3c. Read the comment docs.

@benjamc benjamc changed the base branch from master to development July 16, 2021 08:43
@renesass renesass self-assigned this Jul 16, 2021
@renesass renesass merged commit 1b92381 into development Jul 16, 2021
@renesass renesass deleted the fix_sobol_sequence_729 branch July 16, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants