Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RandomForest): Always cast seed to int #1084

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix(RandomForest): Always cast seed to int #1084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2591549
fix(RandomForest): Always cast `seed` to `int`
eddiebergman Nov 16, 2023
9493721
Update CHANGELOG.md
benjamc Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion smac/model/random_forest/random_forest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ def __init__(
self._rf_opts.compute_law_of_total_variance = False
self._rf: BinaryForest | None = None
self._log_y = log_y
self._rng = regression.default_random_engine(seed)

# Case to `int` incase we get an `np.integer` type
self._rng = regression.default_random_engine(int(seed))

self._n_trees = n_trees
self._n_points_per_tree = n_points_per_tree
Expand Down
Loading