fixed a bug in get_pandas_dataframe() and added get_sorted_runs_dataframe() #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there is a lot of changes in the pull request but most of them are just deleting blanks (somehow my editor automatically did it for me).
The actual changes happen at line 524 and line 509.
At line 524,
.copy()
is added to ensure that eachconfig
is unique and will not be modified in the loop later.This is necessary because a
config_id
can be shared by multiple runs, if a hyperparameter value combination survives all the way from the lowest to the highest budget. We need to do the copy to avoid modifying configs that have the same id but using different budgets.Currently, a part of the content in
all_configs
can look like thisbut instead, it should be
At line 524, I added the function:
Let me know if these are valid changes.