Correct TextMessageCompressor's cache parameter initialising on import #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
marklysze
changed the title
|
Tested it, no |
odoochain
pushed a commit
to odoochain/autogen
that referenced
this pull request
Nov 10, 2024
* initial docs * update docs * Update agent.md * Update memory.md * Update runtime.md --------- Co-authored-by: Jack Gerrits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The TextMessageCompressor's
cacheparameter for__init__()has a default value ofCache.disk(). This is causing it to run on import rather than just on instantiation.This PR changes the default to
Noneand theCache.disk()is executed within__init__.Related issue number
Raised by @omarhurani, #63
Checks