-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Model Client class support for 'auto' speaker selection in Group Chat #65
Conversation
@marklysze have you tested this PR. |
Hey @Hk669, yes, I've tested it and also passes pytest :) I'm in the process of adding some documentation before final review. |
Okay, @Hk669, I've added a documentation page as well, so good for review. |
Thanks @marklysze , let me go through the docs and test it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks Mark!
@Hk669 Have you finished testing? Thank you! |
…hub#65) * initial pipeline * setting branches * renaming workflow to workflows * no needed permissions for building * testing pipeline * testing pipeline * testing pipeline * tweak marketing workflow * tweak paths * change to pwsh * updating run-names * trying if I can pass --no-state as a param * setting --no-state second try * renaming * powershell * add PR number to the run-name * run-name * run name test # 2000 * Confident that this will be the last try --------- Co-authored-by: Kosta Petan <[email protected]>
Why are these changes needed?
If you are you using a custom model client class and want to use it for the the inner speaker selection chat when using
auto
speaker selection, it isn't possible at the moment as it uses the GroupChatManager's config by default.This addresses this bug by registering the custom model client class during the creation of the inner
speaker_selection_agent
.To assign a custom model client class and config to the inner
auto
speaker selection agent you need to register the config and client class with the GroupChat object, see example below.Two new properties exist:
Documentation update to come.
Related issue number
Raised by Jason_DataScience on Discord.
Checks