-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a run
api?
#35
base: main
Are you sure you want to change the base?
Add a run
api?
#35
Conversation
I think this would be useful! Looks straightforward - one thought is whether it's called |
Agree 'run' sounds ambiguous. We need make this self explanatory. What is the use case here? |
self, | ||
message: str, | ||
sender: Optional["Agent"] = None, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the return type here to be more explicit?
How about |
One clarification I'd like to ask is what happens when the same API is invoked twice consecutively. Is it allowed? Does it restart or continue the conversation? It's ambiguous from the api name. |
* add tool call to chat completion agent * refactor function executor; tool executor in chat completion agent * update example * update orchestrator chat demo * handle function execution result message type * format * temp fix for examples. * fix * update chat completion agent
Why are these changes needed?
In many scenarios, we may just want to involve one single agent to finish a straightforward task. Currently, we need to do that through
generate_reply
, which is not easy to use. To improve usability, shall we add thisrun
API? This addition won't break the existing usage ofgenerate_reply
.The change in this PR is an initial proposal. If we agree we should add this
run
API, there are more changes to be made.Related issue number
Checks